Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api 'GetFullSchemaType' to support external package in kcl doc #188

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/kcl/api.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the api label Nov 27, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy November 27, 2023 08:49
@zong-zhe zong-zhe self-assigned this Nov 27, 2023
pkg/kcl/opt.go Outdated Show resolved Hide resolved
@zong-zhe zong-zhe changed the title feat: add api 'GetFullSchemaType' to support external package in kcl doc [WIP] feat: add api 'GetFullSchemaType' to support external package in kcl doc Nov 27, 2023
@Peefy
Copy link
Contributor

Peefy commented Nov 29, 2023

cc @zong-zhe, I have upgrade the kcl artifact to v0.7.0-beta.2 and check passed. Ref:

After this PR has been merged, we can trigger a kcl-go v0.7.0-beta.2 tag for kpm. Then we can trigger a 0.5.0 kpm tag for kcl-go. After all, the v0.7.0 kcl-go tag release!

@coveralls
Copy link

coveralls commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7043204534

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 12 of 16 (75.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.6%) to 63.617%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kcl/api.go 12 16 75.0%
Files with Coverage Reduction New Missed Lines %
kclvm.go 3 70.83%
pkg/tools/validate/validate.go 6 86.36%
Totals Coverage Status
Change from base Build 7001857205: 0.6%
Covered Lines: 2740
Relevant Lines: 4307

💛 - Coveralls

@zong-zhe zong-zhe changed the title [WIP] feat: add api 'GetFullSchemaType' to support external package in kcl doc feat: add api 'GetFullSchemaType' to support external package in kcl doc Nov 30, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a0ae3a2 into kcl-lang:main Nov 30, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants